Author Topic: Discord protocol  (Read 6022 times)

0 Members and 1 Guest are viewing this topic.

Offline VulpixTopic starter

  • Beta Tester
  • *****
  • Posts: 614
  • Country: 00
  • Karma: 15
Re: Discord protocol
« Reply #15 on: 11 02 2017, 22:46:56 »
Nice!

My friend also edited his first post here so it should be easier to track:

https://github.com/miranda-ng/miranda-ng/issues/629
 

Offline ghazan

  • Miranda NG founder
  • Administrator
  • *****
  • Posts: 721
  • Country: ru
  • Karma: 47
  • Jabber ID
Re: Discord protocol
« Reply #16 on: 12 02 2017, 17:54:58 »
highlighting implemented

Group chat log is named after internal channel id (nnnnnnnnnnnnnnnnnnn.log) instead of group#channel.log.
@mnguser what did you mean by that? replacing the unformatted number with a channel nick?
 

Offline mnguser

  • Newbie
  • *
  • Posts: 6
  • Karma: 0
Re: Discord protocol
« Reply #17 on: 13 02 2017, 18:06:30 »
For example the group chat log for IRC is named "#channel - Server.log" , while logs for discord channels are named by it's id instead of names. Is this intentional naming? I suppose, this is made so because group chat channel id is static and channel can be renamed without changing it's numeric id? Not a big deal then. I thought, that having discord group chat log named in the same manner as IRC log "#channel - Group.log" would look better. The difference is that IRC channel on the server name is unique and it's name won't ever change, while it's probably not the case with Discord.
 

Offline ghazan

  • Miranda NG founder
  • Administrator
  • *****
  • Posts: 721
  • Country: ru
  • Karma: 47
  • Jabber ID
Re: Discord protocol
« Reply #18 on: 13 02 2017, 20:15:46 »
roles in chats supported
 

Offline mnguser

  • Newbie
  • *
  • Posts: 6
  • Karma: 0
Re: Discord protocol
« Reply #19 on: 17 02 2017, 23:18:17 »
Thanks! Name highlights seem to be working aswell. Very solid protocol plugin, as far as Miranda's limitations considered.
 

Offline VulpixTopic starter

  • Beta Tester
  • *****
  • Posts: 614
  • Country: 00
  • Karma: 15
Re: Discord protocol
« Reply #20 on: 26 02 2017, 14:47:36 »
Most major bugs fixed (no longer crashing on login).

History retrieved for chat logs as well! (Thanks ghazan!). I recommend enabling text logs for tabsrmm groupchats to take advantage of it the best, but it's fine without that as well.

Not much remains to be done, other than tagging users and sending files to groupchats.
 

Offline mistafist

  • Newbie
  • *
  • Posts: 12
  • Country: 00
  • Karma: 0
Re: Discord protocol
« Reply #21 on: 16 03 2017, 14:35:29 »
How's it going.  When I attempt to use this plugin, 32 bit, it connects then immediately disconnects.  Keepstatus reconnects, but same thing happens over and over.  Some information is received, for example a message will come through upon reconnection.  My log shows this right before disconnecting.

Code: [Select]
[10:31:46 2104] [Discord_1] Got packet: buffer = 2048, opcode = 4, headerSize = 2, final = 0, masked = 0
[10:31:46 2104] [Discord_1] Got packet: buffer = 2048, opcode = 6, headerSize = 2, final = 0, masked = 0
[10:31:46 2104] [Discord_1] Got packet: buffer = 2048, opcode = 12, headerSize = 2, final = 0, masked = 0
[10:31:46 2104] [Discord_1] Got packet: buffer = 2048, opcode = 8, headerSize = 2, final = 0, masked = 0
[10:31:46 2104] [Discord_1] server required to exit
[10:31:46 2104] [Discord_1.Gateway] (05690648:2244) Connection closed internal
[10:31:46 2104] [Discord_1.Gateway] (05690648:4294967295) Connection closed
[10:31:46 2104] [Discord_1] CDiscordProto::ShutdownSession
[10:31:46 2104] [Discord_1] CDiscordProto::OnLoggedOut
[10:31:47 1624] [Discord_1] (0568EBF0:2188) Connection closed internal
[10:31:47 1624] [Discord_1] (0568EBF0:4294967295) Connection closed
[10:31:47 1624] [Discord_1] CDiscordProto::WorkerThread: leaving
 

Offline VulpixTopic starter

  • Beta Tester
  • *****
  • Posts: 614
  • Country: 00
  • Karma: 15
Re: Discord protocol
« Reply #22 on: 16 03 2017, 20:18:45 »
It's kinda akin to this:

https://github.com/miranda-ng/miranda-ng/issues/755

It just happens for some reason. Maybe Ghazan will look into it :)
 

Offline Targaff

  • Newbie
  • *
  • Posts: 1
  • Karma: 0
Re: Discord protocol
« Reply #23 on: 03 05 2017, 23:33:47 »
I'm not especially familiar with the protocol so I'm not sure whether this is feasible, but is there any possibility of being able to select which channels to show in a guild?  For example, I joined a guild/server that has 45 text channels set up, all of which are listed, but I'm only interested in maybe 5 of them.  I was thinking something along the lines of contact menu item for the server that lists the chat rooms and you can choose them from the list.  Alternatively, how about an option to specify a group for Discord chat rooms *other* than the one specified by the messaging plugin?  That would make it easier to clean things up.

No problems with the plugin otherwise, it's great!  Thanks.
 

Offline Ratha

  • Jr. Member
  • **
  • Posts: 99
  • Karma: 2
Re: Discord protocol
« Reply #24 on: 17 05 2018, 17:55:47 »
Is it possible to change/rename the default contact group and "chat rooms" folders to be nested within subfolders? If so whats the syntax for that? "Folder 1\Sub Folder\Actual Folder"?
 

Offline Ratha

  • Jr. Member
  • **
  • Posts: 99
  • Karma: 2
Re: Discord protocol
« Reply #25 on: 18 05 2018, 05:48:29 »
When I send or receive links using Miranda, it logs a whole bunch of extra embedded data for discord a few seconds after sending the message. Is it possible to stop the Discord plugin from displaying and or logging the embedded stuff? It really makes a mess of conversations when the extra info is larger than your original message. (Original message is 2 lines, embed adds an additional 6+ lines minimum and often significantly more text than the original post. Additionally instead of having just one link to click on in the history, theres the original plus the embed copy, plus a preview link too.)

Quote (selected)
11:11:34 PM Ratha I think to fix it showing you as online when you're not, you have to clear the sessions list here:
https://icq.com/session/list/en

11:11:37 PM Ratha
-----------------
Embed: https://icq.com/session/list/en
    link
   Download ICQ on your PC and start using high quality video chat, free messaging and free calls to any country
Preview: https://c.icq.com/images/tint/common/share/share_560.png

VersionInfo
Quote (selected)
CPU: Intel(R) Core(TM) i5-4670K CPU @ 3.40GHz [Intel64 Family 6 Model 60 Stepping 3] [DEP Enabled] [4 CPUs]
Installed RAM: 24521 MBytes
Microsoft Windows 7 Ultimate Edition, 64-bit Service Pack 1 (build 7601)
Internet Explorer: 9.11.9600.18665 (build 99600)
Administrator privileges: Yes
OS Languages: (UI | Locale (User/System)) : English/English | English/English
Free disk space on Miranda partition: 112835 MBytes

Miranda NG Version: 0.95.8 alpha build #19890 (5d651e838c) [running inside WOW64]
Build time: 26 Apr 2018 2:01:02
Profile: C:\Program Files (x86)\Miranda NG\Profiles\Ratha\Ratha.dat (MDBX database driver)
Profile size: 117440512 Bytes
Profile creation date: 29 Dec 2017 16:51:49
Language pack: No language pack installed
Service Mode: No

Active Plugins (18):
¤ AVS.dll v.0.98.1.1 [26 Apr 2018 2:01:06] - Avatar service
¤ CrashDumper.dll v.0.1.0.1 [26 Apr 2018 2:01:34] - Crash dumper
¤ DbEditorPP.dll v.4.0.1.2 [26 Apr 2018 2:01:34] - Database editor++
¤ Dbx_mdbx.dll v.0.95.8.7 [26 Apr 2018 2:02:26] - Miranda NG MDBX database driver
¤ Dbx_mmap.dll v.0.95.8.1 [26 Apr 2018 2:01:14] - Miranda NG mmap database driver
¤ Discord.dll v.0.5.1.2 [26 Apr 2018 2:02:26] - Discord protocol
¤ historypp.dll v.1.5.1.5 [18 Apr 2018 22:19:56] - History++
¤ ICQ.dll v.0.95.8.1 [26 Apr 2018 2:01:10] - IcqOscarJ protocol
¤ ImportTXT.dll v.0.0.1.12 [26 Apr 2018 2:02:46] - Import TXT
¤ PluginUpdater.dll v.0.1.2.5 [26 Apr 2018 2:01:40] - Plugin updater
¤ SeenPlugin.dll v.5.0.5.3 [26 Apr 2018 2:01:22] - Last seen
¤ SkypeWeb.dll v.0.12.2.5 [26 Apr 2018 2:02:20] - Skype protocol (Web)
¤ SpellChecker.dll v.0.2.6.6 [26 Apr 2018 2:02:02] - Spell checker
¤ StatusManager.dll v.1.1.0.4 [2 May 2018 2:01:46] - Status manager
¤ Steam.dll v.0.11.6.3 [26 Apr 2018 2:02:16] - Steam protocol
¤ TabSRMM.dll v.3.5.0.9 [26 Apr 2018 2:01:12] - TabSRMM
¤ Tipper.dll v.2.1.0.7 [26 Apr 2018 2:01:22] - Tipper
¤ YAMN.dll v.0.1.2.6 [26 Apr 2018 2:01:42] - Mail Notifier

Protocols and Accounts:
-------------------------------------------------------------------------------
Discord                  1 - Enabled 0 - Disabled  Loaded
ICQ                      1 - Enabled 1 - Disabled  Loaded
SKYPE                    1 - Enabled 0 - Disabled  Loaded
STEAM                    1 - Enabled 0 - Disabled  Loaded
MetaContacts             1 - Enabled 0 - Disabled  Not Loaded
YAMN                     1 - Enabled 0 - Disabled  Loaded

Icon Packs:
-------------------------------------------------------------------------------
 Flags_icons.dll [26 Apr 2018 2:02:42]
 HistoryPP_icons.dll [26 Apr 2018 2:02:44]
 Proto_Discord.dll [26 Apr 2018 2:02:44]
 Proto_ICQ.dll [26 Apr 2018 2:02:42]
 Proto_MetaContacts.dll [26 Apr 2018 2:02:44]
 Proto_Skype.dll [26 Apr 2018 2:02:44]
 Proto_Steam.dll [26 Apr 2018 2:02:44]
 Proto_Yahoo.dll [13 Feb 2016 22:01:38]
 Proto_YAMN.dll [26 Apr 2018 2:02:44]
 TabSRMM_icons.dll [26 Apr 2018 2:02:44]
 xStatus_ICQ.dll [26 Apr 2018 2:02:44]
« Last Edit: 18 05 2018, 07:20:27 by Ratha »
 

Offline VulpixTopic starter

  • Beta Tester
  • *****
  • Posts: 614
  • Country: 00
  • Karma: 15
Re: Discord protocol
« Reply #26 on: 18 05 2018, 09:35:52 »
The embeds arrive as message modifications; and for now message modifications are generally presented as a new message (though this could now change thanks to the new db format!). I don't particularly mind this happening; my current pet peeves with this method is that in case discord servers are too busy and you type another message before the modified message arrives, the modification is attributed to the person you are talking to. This is because due to how previous DB worked, we could only store one "last message ID" value in the database, and so if the last message was not the one the modification was for, it was incorrectly assumed to not be a message sent by me.

I like how miranda keeps the old message when a message modification occurs, so I see what changed; but I also agree in the case of media embeds and/or links, this is unnecessary. In this case the embed could simply merge nicely. I suppose if you're skilled in Ieview template creation, you could make it behave like discord, in which case the media "update" info modification could serve as a way to get the metadata + preview rendered, much like the discord web client does.

Anyway it is not necessarily a bug, but maybe a not-exactly-properly implemented feature. I suppose you could log a feature request and propose a way to deal with this - on Github :)
 

Offline truefriend-cz

  • Newbie
  • *
  • Posts: 13
  • Karma: 0
Re: Discord protocol
« Reply #27 on: 07 09 2018, 23:54:34 »
I find new problem.
If incoming message to group chat no open new container.

Czech:
Našel jsem problém.
Po přijetí zprávy do skupiny se neotevře kontejner v novém okně.
 

Offline thosrtanner

  • Newbie
  • *
  • Posts: 40
  • Karma: 0
Re: Discord protocol
« Reply #28 on: 09 02 2019, 19:11:51 »
I seem to have got into a very confused state. Under my discord I have two friends listed. A third sent me an invite which I accepted but they are not listed as a friend (though they are listed as such on the discord website).

I am also in a group chat with those 3 people and the chat IMs are coming up as if they were from one of member of the chat (so if the chat members are A, B, and C I get all the chat messages as if they were directly from A)
 

Offline johndoe

  • Newbie
  • *
  • Posts: 13
  • Karma: 0
Re: Discord protocol
« Reply #29 on: 20 02 2019, 20:04:59 »
I seem to have got into a very confused state. Under my discord I have two friends listed. A third sent me an invite which I accepted but they are not listed as a friend (though they are listed as such on the discord website).

I am also in a group chat with those 3 people and the chat IMs are coming up as if they were from one of member of the chat (so if the chat members are A, B, and C I get all the chat messages as if they were directly from A)

I find new problem.
If incoming message to group chat no open new container.

Czech:
Našel jsem problém.
Po přijetí zprávy do skupiny se neotevře kontejner v novém okně.

I also mentioned this in the support forum along with another small problem I was having and it was somewhat ignored so I logged in today to bump it again and saw your post; so this is a widespread issue // or a missing feature right ? not something on our end because it seems like last 3 posts in this topic are about the same issue.

https://forum.miranda-ng.org/index.php?topic=5726.0

Quote (selected)
edit1:also another problem I am having is one of my friends invited me to a private group chat ( not a channel ) just a group chat with some other friends
and ever since that day any message that is posted in the group chat comes as if it was a private msg from him ( even when its other people writing it )
and I can not message him directly either any msg I send to him via miranda goes to that group chat


edit4: well apparently it's on the bugtracker and they are working on it i never check github for changes
« Last Edit: 20 02 2019, 23:26:29 by johndoe »