Author Topic: Memory leak in ConnectionNotify plugin  (Read 4053 times)

0 Members and 1 Guest are viewing this topic.

Offline BigMike

Memory leak in ConnectionNotify plugin
« on: 01 11 2014, 22:03:45 »
It seems, there is a memory leak in ConnectionNotify plugin 0.1.0.5 (Miranda NG 0.95.2 #9966 x64).
Miranda's private bytes set grows up to 300mb when Miranda is running for several hours. This doesn't happen, if the ConnectionNotify plugin is disabled.
 

Offline BigMike

Re: Memory leak in ConnectionNotify plugin
« Reply #1 on: 20 03 2015, 18:13:21 »
The problem is still there with Miranda v0.95.3 build #11706 x64
 

Offline Wishmaster

Re: Memory leak in ConnectionNotify plugin
« Reply #2 on: 20 03 2015, 18:33:26 »
Hm, interesting. We are regularly using Coverity (static code analyzer) and it doesn't report a leak in that plugin. Seems to be a bit more complicated. Can you make a bug report on the bug tracker?

EDIT: Forget it,  I think I found it.

EDIT2: I fixed some leaks, please test with #12455
« Last Edit: 21 03 2015, 08:50:32 by Wishmaster »
 

Offline AnrDaemon

Re: Memory leak in ConnectionNotify plugin
« Reply #3 on: 20 03 2015, 20:07:33 »
 

Offline BigMike

Re: Memory leak in ConnectionNotify plugin
« Reply #4 on: 21 03 2015, 13:38:45 »
The problem seems to be gone with 0.95.4 #12462 x64. Or at least, it's much better now. Thank you.
I've been watching the process for almost an hour and the private bytes size stayed at a relative constant level.
Since in the new build, the ConnectionNotify plugin seems to be broken and to ignore all filter rules, I get masses of popups for connection notifications and (I think) therefore the used memory is going up and down all the time, but as I wrote, it stays on a constant level.
 

Offline Wishmaster

Re: Memory leak in ConnectionNotify plugin
« Reply #5 on: 21 03 2015, 14:16:37 »
Fixed in 12470

EDIT: Development version has been reuploaded.
« Last Edit: 21 03 2015, 17:40:28 by Wishmaster »
 

Offline BigMike

Re: Memory leak in ConnectionNotify plugin
« Reply #6 on: 23 03 2015, 17:58:51 »
Thank you :) All seems to be fine now.