Author Topic: Patch proposal for LotusNotify  (Read 2989 times)

0 Members and 1 Guest are viewing this topic.

Offline pepinlebrefTopic starter

  • Jr. Member
  • **
  • Posts: 77
  • Country: fr
  • Thanked: 2 times
  • Karma: 0
  • Pepin le Bref, father of Charlemagne!
  • Version Info
Patch proposal for LotusNotify
« on: 12 05 2015, 10:25:35 »
Hi there,
Attached a patch proposal for LotusNotify plugin:
- new option to keep or not the connection on error (default is 'keep connection' like today)
- remember newest id even if we don't click on popup (see http://forum.miranda-ng.org/index.php?topic=1198)
 

Offline Wishmaster

Re: Patch proposal for LotusNotify
« Reply #1 on: 12 05 2015, 13:27:51 »
I still disagree with "remember newest id even if we don't click on popup": If this is done, it is likely to miss a message if you don't pay attention to popups. There should be an option for this, and default should be off. And there should be infinite timeouts for those popups.

 (PS: this reminds me on the discussion about popup history)
 

Offline pepinlebrefTopic starter

  • Jr. Member
  • **
  • Posts: 77
  • Country: fr
  • Thanked: 2 times
  • Karma: 0
  • Pepin le Bref, father of Charlemagne!
  • Version Info
Re: Patch proposal for LotusNotify
« Reply #2 on: 12 05 2015, 13:32:08 »
OK, I will rework this with a new option for the newest id...
 

Offline ghazan

Re: Patch proposal for LotusNotify
« Reply #3 on: 12 05 2015, 13:35:35 »
pepinlebref, thanks, accepted.
add the new code over the committed patch, please

Wishmaster,
even if you don't pay attention to popups, a message is stored in the history anyway
and if you don't wanna miss popups, disable a timeout for them
 

Offline Wishmaster

Re: Patch proposal for LotusNotify
« Reply #4 on: 12 05 2015, 13:40:47 »
Wishmaster, even if you don't pay attention to popups, a message is stored in the history anyway and if you don't wanna miss popups, disable a timeout for them
Well, timeout should be fixed infinite for them. Even if it is stored in history, I could still miss it.

pepinlebref, Anyways, thanks for the patch   :THUMBS UP:
 

Offline pepinlebrefTopic starter

  • Jr. Member
  • **
  • Posts: 77
  • Country: fr
  • Thanked: 2 times
  • Karma: 0
  • Pepin le Bref, father of Charlemagne!
  • Version Info
Re: Patch proposal for LotusNotify
« Reply #5 on: 12 05 2015, 19:34:16 »
Quick survey:
While I'm working on the option page, what do you think on using this buttons "pressed" when an option is active?
What about using checkbox in replacement?
 

Offline Wishmaster

Re: Patch proposal for LotusNotify
« Reply #6 on: 13 05 2015, 12:44:22 »
What about using checkbox in replacement?
I agree.  :THUMBS UP:
 

Offline AnrDaemon

Re: Patch proposal for LotusNotify
« Reply #7 on: 14 05 2015, 01:27:43 »
 

Offline pepinlebrefTopic starter

  • Jr. Member
  • **
  • Posts: 77
  • Country: fr
  • Thanked: 2 times
  • Karma: 0
  • Pepin le Bref, father of Charlemagne!
  • Version Info
Odp: Patch proposal for LotusNotify
« Reply #8 on: 15 05 2015, 13:44:15 »
New patch proposal (based on previous accepted patch)
- enhancements on the option page:
   . push buttons replaced by checkboxes
   . re-arrange control place
- new option to select if popup should trigger again if clicked or not
- plugin version increased
 

Offline pepinlebrefTopic starter

  • Jr. Member
  • **
  • Posts: 77
  • Country: fr
  • Thanked: 2 times
  • Karma: 0
  • Pepin le Bref, father of Charlemagne!
  • Version Info
Re: Patch proposal for LotusNotify
« Reply #9 on: 18 05 2015, 18:24:33 »
New patch proposal (based on previous accepted patch)
Did some Dev had a chance to review it?