Tox protocol

[watcher]

Binaries updated to r10245. Please update manually from attachments in the first post.

[Vulpix]

• - Unicode status message issue - fixed (status message refresh by the setter must be performed first but that sounds natural)! 
• - Own Tox ID is now listed - and can be easily copied. 

Great job!

[watcher]

Binaries updated to r10249. Please update manually from attachments in the first post.

[Vulpix]

Latest binaries break buddy-adding. Previous binaries work just fine.

Issue:
Entering Tox ID (or toxme.se) returns "No results" in the add-buddy dialogue window.

Being added still works, so it's just the "search" that's broken.

Tested with both toxme and regular tox id on the latest binary (and obviously only tox id on the previous binary since it didn't have toxme).

[unsane]

I broke searching by tox id specially.
It's not good if you can "find" invalid tox id.
Searching via toxme.se worked a few hours earlier (

[Vulpix]

I see about the tox IDs. I assume it will be turned on when you have a mechanism to make sure you are searching by correct tox ID~

Retesting toxme.se:

Searching by toxme id works - however, only if you omit the @toxme.se component.

I.e. searching for user abcd@toxme.se returns nothing. Searching for user abcd returns user abcd@toxme.se (i.e. his tox ID, which you can then add)

If this is working "as intended", then it may need to be clarified in the search box - instead of "e-mail", it should say something different so that the user who is searching omits the @toxme.se part.

[watcher]

Binaries updated to r10268. Please update manually from attachments in the first post.

[Vulpix]

• Searching via Toxme.se now works':THUMBS UP:
• Changing own nickname now works! Plus, nickname now persists through miranda restarts!

The other option to "add to friend list" is currently being worked on so it actually lets you add anything (even a completely random string, not just a tox ID). I assume this will be modified in a later fix.

As a sidenote, I can see that changing my status (i.e. online, away, DND) works - but for some reason, when you check the status of the protocol in Miranda, the "online" option is always highlighted, regardless of your choice - so it looks like you are Online (even though you have switched to Away, for example). Other clients see the protocol change, so it is just the local view that does not reflect the change.

Current state of tox updated @ sticky.
Post Merge: 22 08 2014, 08:13:10Whilst looking for a reproduction scenario for a different bug, I found another one.

If you "spam"-send messages from miranda (not to miranda, that doesn't break anything), miranda crashes. Windows-ish freeze. No crash dump even with crashdumper installed and enabled.

To reproduce, simply open a tox chat and for example very quickly send "1" (1 enter 1 enter 1 enter). The window will freeze and miranda will stop responding. On the other party's message window, you can see that miranda has disconnected.

[watcher]

Binaries updated to r10288. Protocol icons added. Please update manually from attachments in the first post.

[Vulpix]

Protocol icons work and show properly for contacts in the contact list as well.  Feature listed in the state of tox protocol sticky in "quality of life" section.

Issue with the local protocol status being "stuck" in "online" (even though the actual status can be changed) still prevails.

[watcher]

Issue with the local protocol status being "stuck" in "online" (even though the actual status can be changed) still prevails.

Yes - this is pretty annoying.

[Robyer]

I think that "spam" problem is because toxlibrary isn't thread safe (as I understand from their TODO list, they're working on it). So unsane could fix it in plugin (use thread locks and send one message at once) and/or wait for tox devs to fix it too.

[watcher]

Binaries updated to r10308. Please update manually from attachments in the first post.

[Vulpix]

Changing status now reflects on the local protocol icon in miranda 
Thread-safety workaround seems to be working, I was unable to make miranda crash where I was previously able to make it happen 100% Nope, still broken :< guess we'll have to wait for a fix in toxcore.

Searching/adding buddies is still broken:

trunk/protocols/Tox/src/tox_proto.cpp
Line 168: regex = "^\\s*([A-Za-z]+)(@toxme.se)?\\s*$";

This causes toxme usernames that have other characters in them to be unsearchable. For example, tox username abcd-efgh@toxme.se cannot be found. abcdefgh@toxme.se works, however.

Adding by tox ID causes weird behavior where no matter which tox id you add, it will (after adding) always say "this tox ID is already in your contact list", regardless of whether that's actually true or not.
Being added by tox ID doesn't actually send out add request so the adding is still not functioning.

Looking up a toxme user with regular username abcdef works - but adding doesn't do anything (I assume the add-by-id broke this as well?) Contact request is never sent.
Being added "from the other party" does work and authentication is properly accepted.

[watcher]

Binaries updated to r10315. Please update manually from attachments in the first post.