Tox protocol

[Vulpix]

Filetransfers are somewhat broken, wait for a fixed release, don't update to r11876, it crashes miranda on transfer. :) Unsane has the log, he'll look at it when he has time! :)

[watcher]

Binaries updated to r11880. Please update manually from attachments in the first post. Please backup Tox profile before updating to this revision! It may become corrupted!

[Vulpix]

Filetransfers still broken with the latest build. Unsane has logs, will look at it when he has time again :)

[watcher]

Binaries updated to r11977. Please update manually from attachments in the first post. Please backup Tox profile before updating to this revision! It may become corrupted!

[Vulpix]

File transfers over fast lines are still broken; the transfer goes too fast, then makes the protocol disconnect, and upon reconnecting, miranda is unable to resume correctly:

[9:47:27 0FAC] CToxProto::SendFileAsync: start sending file (0)
[9:48:00 1EC0] CToxProto::OnFileRequest: change file position from 38707443 to 17373312 of file (0)
[9:48:00 1EC0] CToxProto::OnFileRequest: resumption of sending at 17373312 of 64177790 of file (0)
[9:48:29 1EC0] CToxProto::OnFileRequest: change file position from 64177790 to 28253568 of file (0)
[9:48:29 1EC0] CToxProto::OnFileRequest: resumption of sending at 28253568 of 64177790 of file (0)

The resulting file should be 61.2MB, but it ends up being 26.2MB and the final transfer progress bar never disappears.

The "disconnect on sending" happens with uTox as well, but uTox is able to resume correctly.

[Vulpix]

Filetransfers seem to be a lot better now with r11998; some more fixes for chat and so that transfers don't constantly kill connection, but tox is getting a lot better now.

Thanks Unsane/Watcher~!

[watcher]

Binaries updated to r12003. Please update manually from attachments in the first post. Please backup Tox profile before updating to this revision! It may become corrupted!

[watcher]

Binaries updated to r12071. Please update manually from attachments in the first post. Please backup Tox profile before updating to this revision! It may become corrupted!

[Vulpix]

Latest build:

- Sending of single file _vastly_ improved; chat not impaired by file sending + sending is pretty fast.
- Sending of multiple files at once can sometimes cause some files to be declined. Logs have been shared with Unsane.

Generic remark

- it is not possible to utilize the 64bit aspect of tox; support for files bigger than 2GB is not in; unsane knows about this and will try to look at it soon.

Otherwise, really good job on improving that file send :3 it's almost ready now!

[watcher]

Binaries updated to r12083. Please update manually from attachments in the first post. Please backup Tox profile before updating to this revision! It may become corrupted!

[Vulpix]

- The 64bit-ness of the file sending was fixed, it is now possible to send very large files (tested with a 4.1GB file, transferred over 20Mbit line at 1.5MB/s without issues). 

Not much remains to be fixed in the protocol. When I have time I'll quickly check the problem with overwriting/resuming on already-present files.

Furthermore, irungentoo (toxcore maintainer) looked briefly at miranda code for the transfers and said it will help him fix toxcore issue with the filetransfers killing toxcore so that could also happen


- CRASH (still present, not new).
Reproduction scenario:

1) send a file (download dialog appears on miranda recipient side)
2) cancel the file send BEFORE the transfer starts on sender side
3) accept the file @ recipient side
4) Miranda crashes.

Crashlog:

Spoiler

Miranda Crash Report from 12 Feb 2015 19:03:59. Crash Dumper v.0.0.5.2

Likely cause of the crash plugin: Tox protocol

Exception: Access Violation at address 0000000068168374. Reading from address 0000000000050002.

Stack Trace:
---------------------------------------------------------------
0000000068168374 (MSVCR100 0000000068110000): (filename not available) (0): vcwprintf_s
0000000068143EB4 (MSVCR100 0000000068110000): (filename not available) (0): vsnwprintf_l
0000000068143F2D (MSVCR100 0000000068110000): (filename not available) (0): vsnwprintf
000000001200B8B4 (mir_core 0000000012000000): (filename not available) (0): mir_snwprintf
000000018000FAC6 (Tox 0000000180000000): (filename not available) (0): Unload
0000000000441119 (Miranda64 0000000000400000): (filename not available) (0): CallProtoService
000000000043FE97 (Miranda64 0000000000400000): (filename not available) (0): CallContactService
000000001220626C (stdfile 0000000012200000): (filename not available) (0): (function-name not available)
0000000076DE608F (USER32 0000000076DC0000): (filename not available) (0): GetMenuStringW
0000000076DE7792 (USER32 0000000076DC0000): (filename not available) (0): CreateDialogParamW
0000000076DE76C2 (USER32 0000000076DC0000): (filename not available) (0): CreateDialogParamW
0000000076DD9BD1 (USER32 0000000076DC0000): (filename not available) (0): TranslateMessageEx
0000000076DE61C9 (USER32 0000000076DC0000): (filename not available) (0): GetMenuStringW
0000000076DE74C3 (USER32 0000000076DC0000): (filename not available) (0): CreateDialogIndirectParamAorW
0000000076DE7598 (USER32 0000000076DC0000): (filename not available) (0): CreateDialogParamW
00000000122088A1 (stdfile 0000000012200000): (filename not available) (0): (function-name not available)
0000000012204438 (stdfile 0000000012200000): (filename not available) (0): (function-name not available)
0000000076DE79B7 (USER32 0000000076DC0000): (filename not available) (0): CreateDialogParamW
0000000076DE7792 (USER32 0000000076DC0000): (filename not available) (0): CreateDialogParamW
0000000076DE76C2 (USER32 0000000076DC0000): (filename not available) (0): CreateDialogParamW
0000000076DD9BD1 (USER32 0000000076DC0000): (filename not available) (0): TranslateMessageEx
0000000076DD6AA8 (USER32 0000000076DC0000): (filename not available) (0): SetTimer
0000000076DD6BAD (USER32 0000000076DC0000): (filename not available) (0): SendMessageW
000007FEF9A30BBF (COMCTL32 000007FEF9990000): (filename not available) (0): TaskDialog
000007FEF9A347FE (COMCTL32 000007FEF9990000): (filename not available) (0): TaskDialog
0000000076DD9BD1 (USER32 0000000076DC0000): (filename not available) (0): TranslateMessageEx
0000000076DD98DA (USER32 0000000076DC0000): (filename not available) (0): TranslateMessage
0000000076DD67C2 (USER32 0000000076DC0000): (filename not available) (0): IsDialogMessageW
000000000040166C (Miranda64 0000000000400000): (filename not available) (0): (function-name not available)
0000000000477596 (Miranda64 0000000000400000): (filename not available) (0): IcoLib_IsManaged
0000000076ED59ED (kernel32 0000000076EC0000): (filename not available) (0): BaseThreadInitThunk
000000007700C541 (ntdll 0000000076FE0000): (filename not available) (0): RtlUserThreadStart

CPU: Intel(R) Core(TM) i7-4765T CPU @ 2.00GHz [Intel64 Family 6 Model 60 Stepping 3] [DEP Enabled] [8 CPUs]
Installed RAM: 16329 MBytes
Operating System: Microsoft Windows 7 Ultimate Edition, 64-bit Service Pack 1 (build 7601)
Internet Explorer: 8.0.7601.17514 (build 87601)
Administrator privileges: Yes
OS Languages: (UI | Locale (User/System)) : English/English

Miranda NG Version: 0.95.4 alpha build #12091 x64
Build time: 12 Feb 2015 5:42:56
Profile:
Language pack: No language pack installed
Service Mode: No

Active Plugins (45):
  AddContactPlus.dll v.0.9.9.2 [1 Dec 2014 9:52:00] - Add contact+
  AdvaImg.dll v.0.11.0.1 [1 Jan 2015 5:56:26] - Miranda image services
  AIM.dll v.0.11.0.1 [13 Jan 2015 5:47:58] - AIM protocol
  AssocMgr.dll v.0.1.1.0 [20 Dec 2014 5:46:00] - File association manager
  AuthState.dll v.0.0.2.1 [8 Dec 2014 16:53:10] - Authorization state
  AvatarHistory.dll v.0.1.0.1 [17 Jan 2015 13:04:32] - Avatar history
  AVS.dll v.0.95.3.4 [6 Jan 2015 5:43:20] - Avatar service
  ChangeKeyboardLayout.dll v.0.0.1.6 [19 Dec 2014 5:43:44] - Change keyboard layout
  ClientChangeNotify.dll v.0.1.1.3 [19 Dec 2014 5:43:38] - Client change notify
  Clist_modern.dll v.0.9.1.2 [17 Jan 2015 13:00:50] - Modern contact list
  Contacts.dll v.1.6.0.0 [17 Jan 2015 12:58:06] - Send/receive contacts
  CrashDumper.dll v.0.0.5.2 [27 Jan 2015 5:51:14] - Crash dumper
  CSList.dll v.0.1.1.0 [19 Dec 2014 5:42:30] - Custom status list
  Db_autobackups.dll v.0.0.0.10 [11 Jan 2015 10:03:24] - Db autobackuper
  DbEditorPP.dll v.3.2.0.1 [31 Jan 2015 5:52:54] - Database editor++
  Dbx_mmap.dll v.0.95.3.1 [12 Feb 2015 5:43:14] - Miranda NG mmap database driver
  Dummy.dll v.0.1.0.0 [3 Dec 2014 5:49:16] - Dummy protocol
  FileAsMessage.dll v.0.0.2.4 [17 Jan 2015 13:00:52] - File as message
  Fingerprint.dll v.0.1.0.0 [16 Jan 2015 5:56:20] - Fingerprint NG
  Flags.dll v.0.1.0.4 [19 Dec 2014 5:42:28] - Country flags
  Folders.dll v.0.2.0.1 [1 Jan 2015 5:57:30] - Custom profile folders
  HistoryPP.dll v.1.5.1.5 [16 Jan 2015 20:03:46] - History++
  ICQ.dll v.0.11.2.6 [31 Jan 2015 5:48:04] - IcqOscarJ protocol
  IEView.dll v.1.4.0.2 [17 Jan 2015 12:58:24] - IEView
  IgnoreState.dll v.0.0.3.0 [19 Dec 2014 5:42:36] - Ignore state
  Import.dll v.0.95.3.4 [19 Jan 2015 5:45:48] - Import contacts and messages
  Jabber.dll v.0.11.0.4 [28 Jan 2015 5:45:08] - Jabber protocol
  KeepStatus.dll v.0.9.0.2 [24 Dec 2014 5:50:38] - Keep status
  mTextControl.dll v.0.8.0.1 [19 Dec 2014 5:42:40] - Miranda text control
  NewXstatusNotify.dll v.1.4.0.10 [17 Jan 2015 12:58:26] - xStatus notify
  Nudge.dll v.0.1.0.1 [19 Dec 2014 5:42:40] - Nudge
  OpenFolder.dll v.1.1.0.0 [1 Dec 2014 9:53:26] - Open Miranda folder
  PluginUpdater.dll v.0.1.2.4 [7 Feb 2015 5:53:58] - Plugin updater
  PManagerEx.dll v.0.0.0.5 [6 Aug 2014 4:47:42] - Miranda NG profile changer
  Restart.dll v.0.0.6.0 [9 Jul 2013 5:56:52] - Restart
  SeenPlugin.dll v.5.0.4.9 [19 Dec 2014 5:42:48] - Last seen
  SimpleStatusMsg.dll v.1.9.0.4 [19 Dec 2014 5:43:36] - Simple status message
  SmileyAdd.dll v.0.2.3.17 [31 Jan 2015 5:49:28] - SmileyAdd
  StartPosition.dll v.0.2.0.3 [29 Jun 2014 4:50:44] - Start position
  Steam.dll v.0.11.2.2 [8 Feb 2015 6:01:38] - Steam protocol
  TabSRMM.dll v.3.4.0.8 [6 Feb 2015 9:19:24] - TabSRMM
  TopToolBar.dll v.0.8.0.4 [15 Jan 2015 5:51:24] - TopToolBar
  Tox.dll v.0.11.0.6 [10 Feb 2015 21:52:40] - Tox protocol
  UInfoEx.dll v.0.8.5.0 [8 Feb 2015 5:55:04] - User info ext
  Variables.dll v.0.2.3.10 [24 Jan 2015 6:00:32] - Variables

[close]

[unsane]

- CRASH (still present, not new).
Reproduction scenario:

1) send a file (download dialog appears on miranda recipient side)
2) cancel the file send BEFORE the transfer starts on sender side
3) accept the file @ recipient side
4) Miranda crashes.

Should be fixed in r12102

[Vulpix]

Indeed, the transfer window disappears. This could however be somewhat confusing as there is no evidence of what happened. Is it possible to instead make the dialogue button (to accept the transfer) gray and say "Transfer cancelled by sender" or something like that?

Either way, thanks for the quick fix

[Robyer]

Or immediatelly after accepting it in Miranda show error that sender canceled it. I think graying out isn't possible.

[Vulpix]

Actually, now I have a different problem - any transfer gets denied as soon as I click start transfer on the recipient side

And then my miranda crashed O_o (windows freeze, no crashlog).