Steam protocol

[SneakyJoe]

I updated it and got like 200 contacts in my list o_0
I have less than 40 at steam. Who are those people? 

[Vulpix]

I had another weird issue today. I _think_ that my connection went down at around 3:30 am, but I cannot be sure. I wasn't awake then

Either way... my tox reconnected fine it seems. My steam did not. The strange bit is that it shows the protocol as "online" in the miranda status menu - but every contact is offline. Messaging anyone comes back immediately with an error. See log below.

Or actually not, it's too long. Attached as txt.

The data that precedes the log has a _ton_ of contact info and requests, I assume this is what happens when you sign in (all the avatars are pulled etc). I cannot include this.

I can see it comes up as error-timeout / error-timeout, then it starts reconnecting, it seems to have managed to reconnect and then that happens.

What I can think of is - could "KeepStatus" be trying to reconnect whilst the protocol is already reconnecting (and pulling the user data), and thus causing too many requests and eventually causing a crash?

I could probably set a longer delay between reconnect requests or something; it's currently set to 60 seconds.

[SneakyJoe]

It got up to 300. Removed that protocol untill fixed. O_O

[Robyer]

Vulpix, thanks to your log I just found an infinite loop in code, when you switch protocol to offline when there are still some requests in the queue. This resulted in freeze of whole Miranda if it was caused by manual switching to offline. And it could caused freeze just of Steam thread if it was done by Steam itself - e.g. when you received errors.

Hopefully this was your problem :-)


SneakyJoe, they might be people playing game on same server as you, idk. To fix it I need to know when it happens - are they loaded at login or during playing or just chatting? And giving me netlog capturing that problem would be perfect :-)

Btw for quick deleting these unnecessary contacts you can use Quick Search Mod, where you can delete more contacts at once, and add column to find only these not-friends. Just be offline while deleting them as Steam proto sends request to server to delete friend when you delete it from Miranda (for each one), so sending 300 useless requests is... well, useless :-D

[watcher]

Binaries updated to r11267. Please update manually from attachments in the first post.

[Robyer]

SneakyJoe, they might be people playing game on same server as you, idk. To fix it I need to know when it happens - are they loaded at login or during playing or just chatting? And giving me netlog capturing that problem would be perfect :-)

... ok, I started playing some game myself -> problem fixed. ;-)

[watcher]

Binaries updated to r11272. Please update manually from attachments in the first post.

[watcher]

Steam protocol has been added to nightly builds, so no need to update it manually anymore! Big thanks goes to Robyer for not abandoning, fixing and supporting Steam protocol!

[Vulpix]

Props! Now do Tox! Just kidding thanks a bunch for making steam work better!
Post Merge: 08 12 2014, 17:55:35Actually, ever since the update before this one, I keep getting miranda crashes. And it's not a "miranda has crashed" but a "program has stopped responding" so there is no crash log.

The last few lines of netlog aren't very informative:

[18:20:28 1C58] [STEAM_1] (000000001006A5D8:1936) Connection closed internal
[18:20:28 1C58] [STEAM_1] (000000001006A5D8:4294967295) Connection closed
[18:20:48 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
HTTP/1.1 200 OK
[18:20:48 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
Date: Mon, 08 Dec 2014 17:20:42 GMT
expires: Mon, 08 Dec 2014 17:20:42 GMT
Content-Type: application/json; charset=UTF-8
content-length: 56

[18:20:48 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
{
   "pollid": 0,
   "sectimeout": 20,
   "error": "Timeout"
}
[18:20:48 1CAC] [STEAM_1] CSteamProto::PollingThread: https://api.steampowered.com/ISteamWebUserPresenceOAuth/Poll/v0001
[18:21:08 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
HTTP/1.1 200 OK
[18:21:08 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
Date: Mon, 08 Dec 2014 17:21:03 GMT
expires: Mon, 08 Dec 2014 17:21:03 GMT
Content-Type: application/json; charset=UTF-8
content-length: 56

[18:21:08 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
{
   "pollid": 0,
   "sectimeout": 20,
   "error": "Timeout"
}
[18:21:08 1CAC] [STEAM_1] CSteamProto::PollingThread: https://api.steampowered.com/ISteamWebUserPresenceOAuth/Poll/v0001
[18:21:29 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
HTTP/1.1 200 OK
[18:21:29 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
Date: Mon, 08 Dec 2014 17:21:23 GMT
expires: Mon, 08 Dec 2014 17:21:23 GMT
Content-Type: application/json; charset=UTF-8
content-length: 56

[18:21:29 1CAC] [STEAM_1] (000000001006A4A8:1708) Data received
{
   "pollid": 0,
   "sectimeout": 20,
   "error": "Timeout"
}
[18:21:29 1CAC] [STEAM_1] CSteamProto::PollingThread: https://api.steampowered.com/ISteamWebUserPresenceOAuth/Poll/v0001

(nothing since then)

What can I do to help you debug this? It was not happening 2 versions prior. I'm using miranda nightly, VI is in spoiler

VersionInfo

CPU: Intel(R) Core(TM) i7-4765T CPU @ 2.00GHz [Intel64 Family 6 Model 60 Stepping 3] [DEP Enabled] [8 CPUs]
Installed RAM: 16329 MBytes
Operating System: Microsoft Windows 7 Ultimate Edition, 64-bit Service Pack 1 (build 7601)
Internet Explorer: 8.0.7601.17514 (build 87601)
Administrator privileges: Yes
Free disk space on Miranda partition: 965213 MBytes

Miranda NG Version: 0.95.3 alpha build #11275 x64
Build time: 8 Dec 2014 17:01:06
Profile: <cutoff>
Profile size: 207290368 Bytes
Profile creation date: 10 Oct 2014 10:52:56
Language pack: No language pack installed
Service Mode: No

Active Plugins (44):
  AddContactPlus.dll v.0.9.9.2 [1 Dec 2014 9:52:00] - Add contact+
  AdvaImg.dll v.0.11.0.1 [3 Dec 2014 5:43:08] - Miranda image services
  AIM.dll v.0.11.0.1 [3 Dec 2014 5:42:04] - AIM protocol
  AssocMgr.dll v.0.1.1.0 [6 Dec 2014 5:46:54] - File association manager
  AuthState.dll v.0.0.2.1 [8 Dec 2014 16:53:10] - Authorization state
  AvatarHistory.dll v.0.1.0.1 [3 Dec 2014 5:47:02] - Avatar history
  AVS.dll v.0.95.3.4 [3 Dec 2014 5:41:48] - Avatar service
  ChangeKeyboardLayout.dll v.0.0.1.6 [3 Dec 2014 5:44:18] - Change keyboard layout
  ClientChangeNotify.dll v.0.1.1.3 [1 Dec 2014 9:52:02] - Client change notify
  Clist_modern.dll v.0.9.1.1 [6 Dec 2014 5:44:34] - Modern contact list
  Contacts.dll v.1.6.0.0 [1 Dec 2014 9:50:38] - Send/receive contacts
  CrashDumper.dll v.0.0.5.2 [6 Dec 2014 5:45:16] - Crash dumper
  CSList.dll v.0.1.1.0 [1 Dec 2014 9:50:44] - Custom status list
  Db_autobackups.dll v.0.0.0.10 [8 Dec 2014 5:43:56] - Db autobackuper
  DbEditorPP.dll v.3.2.0.1 [3 Dec 2014 5:45:24] - Database editor++
  Dbx_mmap.dll v.0.95.1.3 [8 Dec 2014 16:52:10] - Miranda NG mmap database driver
  Dummy.dll v.0.1.0.0 [3 Dec 2014 5:49:16] - Dummy protocol
  FileAsMessage.dll v.0.0.2.4 [3 Dec 2014 5:44:44] - File as message
  Fingerprint.dll v.0.1.0.0 [8 Dec 2014 5:47:50] - Fingerprint NG
  Flags.dll v.0.1.0.4 [1 Dec 2014 9:50:40] - Country flags
  Folders.dll v.0.2.0.1 [3 Dec 2014 5:43:06] - Custom profile folders
  HistoryPP.dll v.1.5.1.5 [6 Sep 2014 13:30:16] - History++
  ICQ.dll v.0.11.2.6 [6 Dec 2014 5:42:30] - IcqOscarJ protocol
  IEView.dll v.1.4.0.2 [6 Dec 2014 5:43:06] - IEView
  IgnoreState.dll v.0.0.3.0 [1 Dec 2014 9:50:52] - Ignore state
  Import.dll v.0.95.3.3 [20 Oct 2014 4:41:12] - Import contacts and messages
  KeepStatus.dll v.0.9.0.2 [1 Dec 2014 9:51:22] - Keep status
  mTextControl.dll v.0.8.0.1 [6 Dec 2014 5:43:06] - Miranda text control
  NewXstatusNotify.dll v.1.4.0.10 [1 Dec 2014 9:50:56] - xStatus notify
  Nudge.dll v.0.1.0.1 [1 Dec 2014 9:50:56] - Nudge
  OpenFolder.dll v.1.1.0.0 [1 Dec 2014 9:53:26] - Open Miranda folder
  PluginUpdater.dll v.0.1.2.4 [3 Dec 2014 5:45:40] - Plugin updater
  PManagerEx.dll v.0.0.0.5 [6 Aug 2014 4:47:42] - Miranda NG profile changer
  Restart.dll v.0.0.6.0 [9 Jul 2013 5:56:52] - Restart
  SeenPlugin.dll v.5.0.4.9 [1 Dec 2014 9:51:10] - Last seen
  SimpleStatusMsg.dll v.1.9.0.4 [3 Dec 2014 5:44:12] - Simple status message
  SmileyAdd.dll v.0.2.3.17 [3 Dec 2014 5:43:34] - SmileyAdd
  StartPosition.dll v.0.2.0.3 [29 Jun 2014 4:50:44] - Start position
  Steam.dll v.0.11.1.0 [8 Dec 2014 17:00:22] - Steam protocol
  TabSRMM.dll v.3.4.0.5 [8 Dec 2014 5:42:56] - TabSRMM
  TopToolBar.dll v.0.8.0.4 [1 Dec 2014 9:52:14] - TopToolBar
  Tox.dll v.0.11.0.3 [28 Sep 2014 22:12:16] - Tox Protocol
  UInfoEx.dll v.0.8.5.0 [6 Dec 2014 5:43:44] - User info ext
  Variables.dll v.0.2.3.10 [1 Dec 2014 9:51:48] - Variables

Unloadable Plugins (2):
  DbChecker.dll v.0.0.0.0 [8 Dec 2014 16:56:12] - <unknown>

  ImportTXT.dll v.0.0.0.0 [27 Dec 2012 5:42:59] - <unknown>


Protocols and Accounts:
-------------------------------------------------------------------------------
AIM                      0 - Enabled 1 - Disabled  Loaded
Dummy                    8 - Enabled 0 - Disabled  Loaded
ICQ                      0 - Enabled 1 - Disabled  Loaded
STEAM                    1 - Enabled 0 - Disabled  Loaded
TOX                      1 - Enabled 0 - Disabled  Loaded
MetaContacts             1 - Enabled 0 - Disabled  Loaded

Icon Packs:
-------------------------------------------------------------------------------
 Flags_icons.dll [3 Dec 2014 5:47:24]
 Fp_icons.dll [8 Dec 2014 5:47:54]
 HistoryPP_icons.dll [7 Sep 2014 4:48:42]
 Proto_AIM.dll [3 Dec 2014 5:44:24]
 Proto_conn_Skype.dll [3 Oct 2013 6:33:22]
 Proto_Dummy.dll [3 Dec 2014 5:49:16]
 Proto_Facebook.dll [20 Sep 2014 14:36:06]
 Proto_GG.dll [17 Sep 2014 4:48:40]
 Proto_ICQ.dll [6 Dec 2014 5:44:20]
 Proto_IRC.dll [17 Sep 2014 4:48:40]
 Proto_Jabber.dll [24 Sep 2014 4:49:14]
 Proto_MetaContacts.dll [8 Dec 2014 16:59:48]
 Proto_MRA.dll [3 Dec 2014 5:44:22]
 Proto_mRadio.dll [27 Oct 2014 5:51:22]
 Proto_MSN.dll [17 Sep 2014 4:48:42]
 Proto_NewsAggregator.dll [8 Dec 2014 5:47:32]
 Proto_Omegle.dll [1 Dec 2014 9:54:06]
 Proto_Quotes.dll [1 Dec 2014 9:54:46]
 Proto_Skype.dll [7 Aug 2014 4:53:46]
 Proto_Steam.dll [8 Dec 2014 17:00:16]
 Proto_Tlen.dll [3 Dec 2014 5:46:10]
 Proto_Tox.dll [4 Oct 2014 20:14:48]
 Proto_Twitter.dll [3 Dec 2014 5:44:24]
 Proto_Weather.dll [3 Dec 2014 5:46:36]
 Proto_Yahoo.dll [17 Sep 2014 4:48:42]
 Proto_YAMN.dll [3 Dec 2014 5:46:40]
 SecureIM_icons.dll [3 Dec 2014 5:47:24]
 TabSRMM_icons.dll [8 Dec 2014 5:47:06]
 Toolbar_icons.dll [6 Dec 2014 5:44:24]
 UInfoEx_icons.dll [6 Dec 2014 5:44:00]
 Watrack_buttons.dll [1 Dec 2014 9:59:18]
 Watrack_icons.dll [1 Dec 2014 9:59:18]
 xStatus_ICQ.dll [6 Dec 2014 5:42:42]
 xStatus_Jabber.dll [24 Sep 2014 4:47:40]
 xStatus_MRA.dll [3 Dec 2014 5:44:08]

[close]

[Robyer]

Vulpix, try to get to that older version to be really sure it is causing steam. And also make sure you have enabled "catch crashes" in Crash dumper plugin, because "stopped responding" happens often with disabled crash dumper or that option

  And Tox must wait few months...

[Vulpix]

It's definitely steam and my crash dumper is set correctly. My miranda was just running for 2 days with steam set to offline and I've had no issues. Gonna try to check the stack via process explorer when it crashes next time.

[Black Sniper]

Robyer, Hello Prompt, and the problem was solved? After this incident, I am afraid to use the protocol ...
If you need Netlog, I will try reproduce it.

[Vulpix]

Hmm. A new thing that I haven't seen before just happened. The steam contacts who are set as N/A have no protocol icon shown next to them. I assume this is from when you added the extra protocol state handling? Can the icons be amended somehow (to use the overlay)?

[Robyer]

It's definitely steam and my crash dumper is set correctly.

Ok, try to determine and tell me which commit # started it. (At least narrow it to few commit numbers).

The steam contacts who are set as N/A have no protocol icon shown next to them.

I'm loading MirVer info, maybe it replaces your Client icon with blank icon? (Because in Fingerprint there is no Steam support yet)

Robyer, Hello Prompt, and the problem was solved? After this incident, I am afraid to use the protocol ...

Yes, I fixed it yesterday. But it's not serious problem, you can easily and quickly delete all that other people.

[Vulpix]

Ok, try to determine and tell me which commit # started it. (At least narrow it to few commit numbers).

I believe I first had it happen after you fixed the loop, i.e. commit 11267.

       @11290      13 hours    robyer    Steam: Support for sending to server how long are we idle
      @11289      13 hours    robyer    Steam: Option to use big avatars (disabled by default) Until now big …
      @11272      25 hours    robyer    Steam: Add new contacts at login only, so it won't feed our clist with …
      @11267      36 hours    robyer    Steam: Fix infinite loop when switching to offline when there are still …

Is it possible for int count = requestsQueue.getCount();  to be null or something like that?

I'm loading MirVer info, maybe it replaces your Client icon with blank icon? (Because in Fingerprint there is no Steam support yet)

I don't think that's it. I checked the other contacts that have MirVer (steam - mobile) the same and their status shows. What doesn't show is the entire protocol icon when the contact is set as N/A (not available). When they're away, online, offline - it works just fine with the overlay, see pic below. Those two were set as NA.