Steam protocol

[dartraiden]

Try the last build.

[KentKareless]

I am using Commit https://github.com/miranda-ng/miranda-ng/commit/4c3d77032316bc8814cddc00d020ba00d4533999 (see attached version info) and it still does not work for me.
I also tried deleting the existing AccessToken, RefreshToken and SessionId keys in the DB but still no dice.

If i remember correctly the commit that broke it for me was: https://github.com/miranda-ng/miranda-ng/commit/4d6ff1f6d3a818998364004e032d640675918ce7
But i am not 100% sure about that.

Does it still work fine for you?

[ghazan]

KentKareless,
well, in that log there was a problem with relogin, and it is definitely fixed.
you cannot send messages, that's true, bug Miranda is already able to receive them

[KentKareless]

well, in that log there was a problem with relogin, and it is definitely fixed.

Yes, that's correct!
I now get a completely different netlog (see attachment).
Login still does not work though.

It might be related to the fact that i am have an authenticator connected to my steam account.

P.S.: Thank you very much for working on Steam chat integration!

[ghazan]

It might be related to the fact that i am have an authenticator connected to my steam account.

Obviously, Steam required Miranda to validate your login attempt using TOTP code, but the code being sent doesn't make Steam happy.
BTW, are you sure that this code is only 5 chars long? I have read somewhere, that only email notification code has 5 letters, while TOTP code is longer

[ghazan]

KentKareless,
I've uploaded a build with more error info, please make this log again

[KentKareless]

I just did!
Here it is (see attachment).

The TOTP code is definitely only 5 characters long!

[ghazan]

Okay, now it's possible to see the error code
DuplicateRequest = 29 - wtf does it mean?... very interesting

// Observed results can be InvalidLoginAuthCode, TwoFactorCodeMismatch, Expired, DuplicateRequest.
// DuplicateRequest happens when accepting the prompt in the mobile app, and then trying to send guard code here,
// we do not throw on it here because authentication will succeed on the next poll.

@KentKareless
Okay, let's ignore this trash, next build will be available in 30 minutes

[KentKareless]

Logging in works fine now!
Thanks for the quick fix! 

[KentKareless]

I have an idea of why the "Duplicate request" error happens:

It might be related to the fact, that i am running the builtin Steam chat and then connecting with Miranda NG.
Even right now with the fix that just ignores the error, the builtin Steam chat is disconnected when Miranda NG connects.

It would be really nice if it would be possible to be connected with Miranda NG and the builtin chat client, but i am not sure if that is technically possible.