Steam protocol

[Wishmaster]

Fixed. Please upgrade Miranda NG to the latest version.

[Corak]

Not fixed, I'm already at latest alpha update and getting such crashes:


1. http://forum.miranda-ng.org/index.php?action=dlattach;topic=1222.0;attach=1660

steam_contacts.cpp

Code: [Select]

Likely cause of the crash plugin: Steam protocol

Exception: Access Violation at address 120821F7. Reading from address 014B4000.

Stack Trace:
---------------------------------------------------------------
120821F7 (libjson 12080000): c:\program files (x86)\microsoft visual studio 10.0\vc\include\xstring (930): std::basic_string<char,std::char_traits<char>,std::allocator<char> >::assign
12083BDE (libjson 12080000): e:\sources\miranda_ng_compilation\libs\libjson\src\libjson.cpp (100): json_parse
16EA8F1B (Steam 16EA0000): e:\sources\miranda_ng_compilation\protocols\steam\src\steam_contacts.cpp (492): CSteamProto::OnGotUserSummaries
16EA4890 (Steam 16EA0000): e:\sources\miranda_ng_compilation\protocols\steam\src\steam_request.cpp (37): SteamHttpResponse
16EA9A51 (Steam 16EA0000): e:\sources\miranda_ng_compilation\protocols\steam\src\request_queue.cpp (77): RequestQueue::Execute
16EA9ADB (Steam 16EA0000): e:\sources\miranda_ng_compilation\protocols\steam\src\request_queue.cpp (104): RequestQueue::WorkerThread
1224C599 (mir_core 12240000): e:\sources\miranda_ng_compilation\src\mir_core\src\threads.cpp (119): forkthread_r
78AFC3D4 (MSVCR100 78AA0000): (filename not available) (0): endthread
78AFC474 (MSVCR100 78AA0000): (filename not available) (0): endthread
7C80B729 (kernel32 7C800000): (filename not available) (0): GetModuleFileNameA

[close]

2.
+ With debug mode netlog
http://forum.miranda-ng.org/index.php?action=dlattach;topic=1222.0;attach=1666

PollingThread

Code: [Select]

Likely cause of the crash plugin: Steam protocol

Exception: Access Violation at address 120821F7. Reading from address 01527000.

Stack Trace:
---------------------------------------------------------------
120821F7 (libjson 12080000): c:\program files (x86)\microsoft visual studio 10.0\vc\include\xstring (930): std::basic_string<char,std::char_traits<char>,std::allocator<char> >::assign
12083BDE (libjson 12080000): e:\sources\miranda_ng_compilation\libs\libjson\src\libjson.cpp (100): json_parse
16EAA312 (Steam 16EA0000): e:\sources\miranda_ng_compilation\protocols\steam\src\steam_pooling.cpp (194): CSteamProto::PollingThread
1224C554 (mir_core 12240000): e:\sources\miranda_ng_compilation\src\mir_core\src\threads.cpp (154): forkthreadex_r
78AFC556 (MSVCR100 78AA0000): (filename not available) (0): endthreadex
78AFC600 (MSVCR100 78AA0000): (filename not available) (0): endthreadex
7C80B729 (kernel32 7C800000): (filename not available) (0): GetModuleFileNameA

[close]

3. http://forum.miranda-ng.org/index.php?action=dlattach;topic=1222.0;attach=1662

OnAuthorizationError

Code: [Select]

Likely cause of the crash plugin: Steam protocol

Exception: Access Violation at address 1224A03D. Reading from address 00000374.

Stack Trace:
---------------------------------------------------------------
1224A03D (mir_core 12240000): e:\sources\miranda_ng_compilation\src\mir_core\src\ui_utils.cpp (32): CompareDialogs
122504A7 (mir_core 12240000): e:\sources\miranda_ng_compilation\src\mir_core\src\lists.cpp (138): List_GetIndex
12250511 (mir_core 12240000): e:\sources\miranda_ng_compilation\src\mir_core\src\lists.cpp (56): List_Find
12249FFE (mir_core 12240000): e:\sources\miranda_ng_compilation\src\mir_core\src\ui_utils.cpp (276): CDlgBase::Find
1224A8CE (mir_core 12240000): e:\sources\miranda_ng_compilation\src\mir_core\src\ui_utils.cpp (238): CDlgBase::GlobalDlgProc
7E368734 (USER32 7E360000): (filename not available) (0): GetDC
7E373CE4 (USER32 7E360000): (filename not available) (0): EnumDisplaySettingsA
7E373B30 (USER32 7E360000): (filename not available) (0): EnumDisplaySettingsA
7E373D5C (USER32 7E360000): (filename not available) (0): DefDlgProcW
7E368734 (USER32 7E360000): (filename not available) (0): GetDC
7E368816 (USER32 7E360000): (filename not available) (0): GetDC
7E3689CD (USER32 7E360000): (filename not available) (0): GetWindowLongW
7E368A10 (USER32 7E360000): (filename not available) (0): DispatchMessageW
7E3774FF (USER32 7E360000): (filename not available) (0): IsDialogMessageW
7E37763C (USER32 7E360000): (filename not available) (0): CallMsgFilterW
7E3749C4 (USER32 7E360000): (filename not available) (0): GetCursorFrameInfo
7E374A06 (USER32 7E360000): (filename not available) (0): DialogBoxIndirectParamAorW
7E3747EA (USER32 7E360000): (filename not available) (0): DialogBoxParamW
1224A908 (mir_core 12240000): e:\sources\miranda_ng_compilation\src\mir_core\src\ui_utils.cpp (79): CDlgBase::DoModal
16EA62EC (Steam 16EA0000): e:\sources\miranda_ng_compilation\protocols\steam\src\steam_login.cpp (148): CSteamProto::OnAuthorizationError
16EA6B3C (Steam 16EA0000): e:\sources\miranda_ng_compilation\protocols\steam\src\steam_login.cpp (103): CSteamProto::OnAuthorization
78AB016A (MSVCR100 78AA0000): (filename not available) (0): free


[close]

[Wishmaster]

It's a completly different crash!

Please stop putting different crash logs in description and in the attatchment! Stop mixing them together!

[Corak]

>It's a completly different crash!
>Please stop putting different crash logs in description and in the attatchment! Stop mixing them together!

Ehm...
 

I know it's three different crashes related with Steam, so I put it there in DIFFERENT spoilers and different files in attach. But they ALL happened in latest day and CrashLogs for them are matched. I'm not "mixing" them - just look in attach and you will find they all Match the text in spoiler.
 So I dont understand why you are so surprised and angry.
I always doing this way if I got many different crashes on one protocol.
They all Related to Steam. Where and HOW to put them then? Give an example how you prefer.

[Wishmaster]

Well, please keep them in this forum, it is very confusing if some are on the tracker but some are on the forum. Also in #1011, you put two different crashes together, and it seems you created quite some duplicates on the tracker. Also, if a crash doesn't get fixed, it's not quite helpful to post the same log again.


I'll see if I can fix anything

[Corak]

I place on tracker depending on a protocol or a core. I know that someone reads about crashes only there and always will answer only there, about core I'm writing to bug tracker, about those protocols - to forum.

#1011 - ок, I will create another ticket for this crash too (it's just very simpilar to that I already had).

And I dont really create duplicates on tracker:
http://trac.miranda-ng.org/query?status=!closed&reporter=Corak
If there once was such "duplicates" - i found them easy , and just give a link to this ticket (in both tickets comments) and close one (if it's just mine duplicate tickets).

>Also, if a crash doesn't get fixed, it's not quite helpful to post the same log again.

But I don't post the same log.

Yes, I know, and understand. But it's seems "different" crashes but they have some simpilarities so I wrote "it's not fixed"... Anyway it just happened, so I posted it here. I dont understand why you are so angry about it...

Also.. One thing - If I cannot enter a key - it just dont works. When SSL are falled, and it keeps asking and asking me a Key. I pressing "cancel" button - and it opens window again. Is there any way to REALLY cancel? I even tried to place protocol offline - and it didnt helps - Steam Guard window opens again and again..
The only way to stop this madness is seems to disable plugin or steam account in account manager or restart Miranda.

Log in when triying to connect with real key on mail

[close]

It's happening every time when my entire network connection failed - and just cannot login anymore.. Only restarting miranda seems helps and it authorises.

+If I disable it in account manager when this window opened i got such core crash (DestroyServiceFunction):
http://trac.miranda-ng.org/ticket/1028


Thanks)

[Wishmaster]

Hi, I tried to fix the crashes in Stream, will read the rest later.

[Corak]

Thanks!

* Unsane gave me some code to build, to make steam plugin create dumps in netlog (without "NLHRF_NODUMPSEND"):

Code: [Select]

http_request.h:70
-- flags = NLHRF_HTTP11 | NLHRF_SSL | NLHRF_NODUMPSEND | NLHRF_DUMPASTEXT;
++ flags = NLHRF_HTTP11 | NLHRF_SSL | NLHRF_DUMPASTEXT;

I built this dll and using it now.
And just now I got one of the crashes and  here's netlog and crashdump on it (related with "CSteamProto::PollingThread")

http://forum.miranda-ng.org/index.php?action=dlattach;topic=1222.0;attach=1666

If it helps somehow

[Wishmaster]

Well, thats useless, its build r15363, wait for r15365 (my fix) and post new crash report with that. "CSteamProto::PollingThread" should be fixed.

[Corak]

Thanks! 
I will build them now from svn sources and write if some crash repeated or it's fixed.

[Corak]

CSteamProto::PollingThread" should be fixed.

Just got another crash on CSteamProto::PollingThread
Protocol plugin is latest build.

Yes. This is the only crash repeated twice today - one on my build with "dump" from latest svn.. another one on latest update from nightly build (also updated through updater today). So it's not fixed still...
Both crashes after network connection falled and restored.

But most other crashes seems not repeating now.

[Wishmaster]

Should be fixed as well

[Corak]

* "PollingThread" crash just repeated. Reopened.
http://trac.miranda-ng.org/ticket/1024

[Wishmaster]

Fixed

[Corak]

Thanks. Updating.