Miranda NG Official Community Forum

Forum for English speaking Miranda NG users => Bug reports => Topic started by: borut on 08 01 2016, 11:25:42

Title: Wrong status protocols
Post by: borut on 08 01 2016, 11:25:42
For some time the contacts available (all protocols) have the status offline. Only when you change the "hide offline contacts" and returning to the "Show offline contacts", everything goes back to normal. Please improve.
Title: Re: Wrong status protocols
Post by: Vulpix on 08 01 2016, 14:11:48
Is it http://forum.miranda-ng.org/index.php?topic=4353.msg14885#msg14885 ?

I find that anything that "refreshes" the contact list temporarily fixes the issue.
Title: Re: Wrong status protocols
Post by: borut on 08 01 2016, 18:43:48
The Guide did not help.  :(
Title: Re: Wrong status protocols
Post by: Vulpix on 08 01 2016, 19:30:16
The Guide did not help.  :(

? what guide.

There is no guide :3 This is an unfixed bug and nothing you can do to fix it. You can "temporarily" fix it by doing anything that refreshes the contact list - such as switching offline/online contact display or changing display lines. Sadly :(
Title: Re: Wrong status protocols
Post by: Robyer on 09 01 2016, 10:31:03
Vulpix, is it easily reproducible (how often it happens)? Do you remember when it started? Does it work in latest stable or is it much older? Is it problem only of clist_modern or does it affect other clists as well?
Title: Re: Wrong status protocols
Post by: Vulpix on 09 01 2016, 11:17:09
Vulpix, is it easily reproducible (how often it happens)? Do you remember when it started? Does it work in latest stable or is it much older? Is it problem only of clist_modern or does it affect other clists as well?

I gave wishmaster a CLEAN profile where you can reproduce it 10/10 times.

I think it started about 2 or 3 months ago.

I don't know if it works in latest stable, I cannot check though since most of the protocols I use don't work there.

I don't know, I only use clist_modern, but I could try if you want.
Title: Re: Wrong status protocols
Post by: Wishmaster on 09 01 2016, 11:24:42
I gave wishmaster a CLEAN profile where you can reproduce it 10/10 times.
What?  ???
Title: Re: Wrong status protocols
Post by: borut on 09 01 2016, 11:53:29
Today these tips is better, because only Facebook hangs on "Offline"  :-\
Title: Re: Wrong status protocols
Post by: Goraf on 09 01 2016, 12:03:28
As far as I remember it was working in dev version
http://trac.miranda-ng.org/ticket/1104

And this bug can't be older than 2 to 3 months (like Vulpix said)
Title: Odp: Wrong status protocols
Post by: borut on 09 01 2016, 12:08:11
Still exists in version "0. 95. 5 alpha build # 16064"
Title: Odp: Wrong status protocols
Post by: Robyer on 09 01 2016, 12:37:09
It would be good to find the particular commit which introduced this problem. We can ask watcher to prepare us various releases from different commits so you (anybody interested) can test it and narrow down the time when it started.
Title: Re: Wrong status protocols
Post by: Vulpix on 09 01 2016, 15:42:49
What?  ???

Sorry, not wishmaster D: Watcher. You both start with W, and I was tired.

Also what is this vote :D do you have a problem with this thread? :D
Title: Re: Wrong status protocols
Post by: Vulpix on 09 01 2016, 18:19:01
As far as I remember it was working in dev version
http://trac.miranda-ng.org/ticket/1104

And this bug can't be older than 2 to 3 months (like Vulpix said)

This is when I spoke about it with Watcher:
Vulpix, 04.11.2015 14:20:07:
Do you also have that issue with statuses?

Vulpix, 14:20:11:
in miranda

Vulpix, 14:20:14:
If you use row items?

Vulpix, 14:20:30:
I dunno if I should create a ticket or leave it on the forums, but it's pretty annoying

So that's 2 months ago, it was there for a few days already when it started bugging me.


It should be one of these, I'm guessing?:

http://trac.miranda-ng.org/changeset/15652
http://trac.miranda-ng.org/changeset/15631

Maybe:

   int GetStatusForContact(MCONTACT hContact, char *szProto)
315   315   {
316    -           return (szProto) ? (int)(db_get_w(hContact, szProto, "Status", ID_STATUS_OFFLINE)) : ID_STATUS_OFFLINE;
+    316           return (szProto) ? db_get_w(hContact, szProto, "Status", ID_STATUS_OFFLINE) : ID_STATUS_OFFLINE;
317   317   }
318   318   

I dunno, I'm not a programmer, not sure why the type cast would be there and then not...
Title: Re: Wrong status protocols
Post by: Wishmaster on 09 01 2016, 19:50:02
Maybe:

   int GetStatusForContact(MCONTACT hContact, char *szProto)
315   315   {
316    -           return (szProto) ? (int)(db_get_w(hContact, szProto, "Status", ID_STATUS_OFFLINE)) : ID_STATUS_OFFLINE;
+    316           return (szProto) ? db_get_w(hContact, szProto, "Status", ID_STATUS_OFFLINE) : ID_STATUS_OFFLINE;
317   317   }
318   318   

I dunno, I'm not a programmer, not sure why the type cast would be there and then not...

No idea why the cast was there, but it definately was uneeded. But both variants are correct, actually.
Title: Re: Wrong status protocols
Post by: Goraf on 20 01 2016, 17:57:43
I've found it in the first shot  ;D  Vulpix gave me enough info in his posts. The problem is in:

http://trac.miranda-ng.org/changeset/15652


15651 - working
15653 - not working
Title: Re: Wrong status protocols
Post by: Vulpix on 12 03 2016, 14:00:49
Any news on this? It is pretty annyoing... and since we know which commit caused it, it shouldn't be too difficult to find out why and fix it up. Pretty please~
Title: Re: Wrong status protocols
Post by: Vulpix on 22 03 2016, 17:41:52
Got in touch with Ghazan, supplied a profile where it happens and he managed to fix it!

http://trac.miranda-ng.org/changeset/16523/

Thanks!