Miranda NG Official Community Forum

Forum for English speaking Miranda NG users => Bug reports => Topic started by: omniwolf on 18 06 2015, 00:39:50

Title: Twitter protocol - retweets are missing tweet body
Post by: omniwolf on 18 06 2015, 00:39:50

Hi guys,

Just updated to the development set of plugins (I'm using the plugin updater and chose development, so i'm not running a mix of prod and dev).
I have noticed that the twitter protocol now truncates retweets.
Where it should say:

abcnews: RT @abcnewsPerth Perth news newsy news blah blah

it just says:

abcnews: RT @abcnewsPerth

All retweets seem to have this issue - the message only contains the tweeter's name, but not their actual tweet.
I'm using the group chat feature, if that helps.

Thanks.

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: omniwolf on 02 07 2015, 00:06:49

bump!

If i reload the non development version of miranda and twitter, then retweets work again, so i know it's not a Twitter API issue, it's a miranda issue.
I had a quick look at the source, the RT code is from line 228 in the twitter.cpp code.  Ghazan made some changes to this code about 5 weeks ago here:

http://trac.miranda-ng.org/changeset/13835/

and i guess he didn't test it. 

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: Wishmaster on 02 07 2015, 10:18:24

Quote from: omniwolf on 02 07 2015, 00:06:49

http://trac.miranda-ng.org/changeset/13835/ and i guess he didn't test it.

Hm, I don't use Twitter, but quickly looking at that commit, it seems to be correct (assuming that the previous code worked, I didn't check the exact JSON format). Maybe I'll add some more logging.

Title: Re:Twitter protocol - retweets are missing tweet body
Post by: Robyer on 03 07 2015, 07:10:28

I think it didn't worked even before. I was using twitter plugin for few months and I never saw correct retweet's text (at least I don't remember that). So it must be older change...

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: Wishmaster on 03 07 2015, 19:04:40

I believe I fixed it, here (https://dl.dropboxusercontent.com/u/68023032/miranda/Twitter.dll) is x64 version, please test!

PS: It was appearently r13248 (http://trac.miranda-ng.org/changeset/13248/#file3) (after "// here we grab the "retweeted_status" um.. section?  it's in here that all the info we need is")

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: Robyer on 03 07 2015, 20:53:05

Wishmaster, could you maybe commit your changes?

Or provide also 32 bit version, please. :)

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: Wishmaster on 03 07 2015, 20:57:05

Quote from: Robyer on 03 07 2015, 20:53:05

Wishmaster, could you maybe commit your changes? Or provide also 32 bit version, please. :)

Done :)

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: Robyer on 04 07 2015, 04:25:53

Wishmaster, hmm, probably it's still not fixed.

I'm seeing just "RT @ " as content of retweeted tweets.

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: Wishmaster on 04 07 2015, 06:52:38

Please try this patch

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: Wishmaster on 06 07 2015, 17:20:59

Quote from: Wishmaster on 04 07 2015, 06:52:38

Please try this patch

Okay, I just comitted it. Please give feedback.

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: omniwolf on 07 07 2015, 03:41:41

If you can post a 64bit compilation i can test

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: watcher on 07 07 2015, 06:53:54

omniwolf, you can already test it, its in updater, check for updates.

Title: Re: Twitter protocol - retweets are missing tweet body
Post by: omniwolf on 08 07 2015, 23:35:28

hmm i tried and there was no update, but it's come through this morning.
The issue is fixed, thanks :)