Miranda NG Official Community Forum

Forum for English speaking Miranda NG users => Development => Topic started by: pepinlebref on 12 05 2015, 10:25:35

Title: Patch proposal for LotusNotify
Post by: pepinlebref on 12 05 2015, 10:25:35
Hi there,
Attached a patch proposal for LotusNotify plugin:
- new option to keep or not the connection on error (default is 'keep connection' like today)
- remember newest id even if we don't click on popup (see http://forum.miranda-ng.org/index.php?topic=1198)
Title: Re: Patch proposal for LotusNotify
Post by: Wishmaster on 12 05 2015, 13:27:51
I still disagree with "remember newest id even if we don't click on popup": If this is done, it is likely to miss a message if you don't pay attention to popups. There should be an option for this, and default should be off. And there should be infinite timeouts for those popups.

 (PS: this reminds me on the discussion about popup history)
Title: Re: Patch proposal for LotusNotify
Post by: pepinlebref on 12 05 2015, 13:32:08
OK, I will rework this with a new option for the newest id...
Title: Re: Patch proposal for LotusNotify
Post by: ghazan on 12 05 2015, 13:35:35
pepinlebref, thanks, accepted.
add the new code over the committed patch, please

Wishmaster,
even if you don't pay attention to popups, a message is stored in the history anyway
and if you don't wanna miss popups, disable a timeout for them
Title: Re: Patch proposal for LotusNotify
Post by: Wishmaster on 12 05 2015, 13:40:47
Wishmaster, even if you don't pay attention to popups, a message is stored in the history anyway and if you don't wanna miss popups, disable a timeout for them
Well, timeout should be fixed infinite for them. Even if it is stored in history, I could still miss it.

pepinlebref, Anyways, thanks for the patch   :THUMBS UP:
Title: Re: Patch proposal for LotusNotify
Post by: pepinlebref on 12 05 2015, 19:34:16
Quick survey:
While I'm working on the option page, what do you think on using this buttons "pressed" when an option is active?
What about using checkbox in replacement?
Title: Re: Patch proposal for LotusNotify
Post by: Wishmaster on 13 05 2015, 12:44:22
What about using checkbox in replacement?
I agree.  :THUMBS UP:
Title: Re: Patch proposal for LotusNotify
Post by: AnrDaemon on 14 05 2015, 01:27:43
What about using checkbox in replacement?
http://hallofshame.gp.co.at/controls.htm
Title: Odp: Patch proposal for LotusNotify
Post by: pepinlebref on 15 05 2015, 13:44:15
New patch proposal (based on previous accepted patch)
- enhancements on the option page:
   . push buttons replaced by checkboxes
   . re-arrange control place
- new option to select if popup should trigger again if clicked or not
- plugin version increased
Title: Re: Patch proposal for LotusNotify
Post by: pepinlebref on 18 05 2015, 18:24:33
New patch proposal (based on previous accepted patch)
Did some Dev had a chance to review it?